Mesh loaders kevin #199
Mesh loaders kevin #199
Conversation
| const uint64_t vertexBufferAddress = geom.vertexBufferAddress; | ||
| const uint64_t indexBufferAddress = geom.indexBufferAddress; | ||
| const uint64_t normalBufferAddress = geom.normalBufferAddress; |
There was a problem hiding this comment.
where are you handling calculating smooth vertex normals vs cross product from positions
|
|
||
| uint32_t vertexStride : 29; | ||
| uint32_t objType : 29; | ||
| uint32_t indexType : 2; // 16 bit, 32 bit or none | ||
| uint32_t smoothNormals : 1; // flat for cube, rectangle, disk |
There was a problem hiding this comment.
this should be inferred from normalBufferAddress!=0ull
|
|
||
| uint32_t vertexStride : 29; | ||
| uint32_t objType : 29; | ||
| uint32_t indexType : 2; // 16 bit, 32 bit or none |
There was a problem hiding this comment.
none should be inferred from indexBufferAddress==0 so you only need 1 bit
| OT_UNKNOWN = std::numeric_limits<uint8_t>::max() | ||
| }; | ||
|
|
||
| static constexpr uint32_t s_smoothNormals[OT_COUNT] = { 0, 1, 1, 0, 1, 1 }; |
There was a problem hiding this comment.
you can deduce from the Geometry not having a normal view
| struct ObjectMeta | ||
| { | ||
| ObjectType type = OT_UNKNOWN; | ||
| std::string_view name = "Unknown"; | ||
| }; | ||
|
|
||
| struct ObjectDrawHookCpu | ||
| { | ||
| nbl::core::matrix3x4SIMD model; | ||
| ObjectMeta meta; | ||
| }; | ||
|
|
||
| enum GeometryShader | ||
| { | ||
| GP_BASIC = 0, | ||
| GP_CONE, | ||
| GP_ICO, | ||
|
|
||
| GP_COUNT | ||
| }; | ||
|
|
||
| struct ReferenceObjectCpu | ||
| { | ||
| ObjectMeta meta; | ||
| core::matrix3x4SIMD transform; | ||
| core::smart_refctd_ptr<ICPUPolygonGeometry> data; | ||
| }; |
There was a problem hiding this comment.
clean this up, there's no geometry shader, the model and transform matrices are probably not used
| struct Bindings | ||
| { | ||
| nbl::asset::SBufferBinding<IGPUBuffer> vertex, index; | ||
| }; | ||
|
|
||
| ObjectMeta meta; | ||
| Bindings bindings; | ||
| uint32_t vertexStride; | ||
| nbl::asset::E_INDEX_TYPE indexType = nbl::asset::E_INDEX_TYPE::EIT_UNKNOWN; | ||
| uint32_t indexCount = {}; | ||
|
|
||
| const bool useIndex() const | ||
| { | ||
| return bindings.index.buffer && (indexType != E_INDEX_TYPE::EIT_UNKNOWN); | ||
| } |
There was a problem hiding this comment.
lots unused stuff, or things which can be deduces from IGPUPolygonGeometry
| uint64_t normalBufferAddress; | ||
|
|
||
| uint32_t vertexStride : 26; | ||
| uint32_t objType: 3; |
There was a problem hiding this comment.
again, you've got indexType using 2 bits and smoothNormals where info can be deduced from index and normal BDA being 0 or not
|
btw remove |
Fix example 9, 67, 71